This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Move to frostdb on a private fork #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
simonswine
approved these changes
Jun 28, 2022
.github/workflows/test.yml
Outdated
Comment on lines
54
to
57
| - name: Configure git for private modules | ||
| env: | ||
| TOKEN: ${{ secrets.GRAFANABOT_PAT }} | ||
| run: git config --global url."https://grafanabot:${TOKEN}@github.com".insteadOf "https://github.com" |
There was a problem hiding this comment.
I would use the same approach to both pipelines. But you might already have tried that?
Suggested change
| - name: Configure git for private modules | |
| env: | |
| TOKEN: ${{ secrets.GRAFANABOT_PAT }} | |
| run: git config --global url."https://grafanabot:${TOKEN}@github.com".insteadOf "https://github.com" | |
| - uses: webfactory/[email protected] | |
| with: | |
| ssh-private-key: ${{ secrets.GO_MOD_SSH_PRIVATE_KEY }} |
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
Move to frostdb on a private fork
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us speed up the development cycle and test out some fixes for frostDB.
Still need to rebase and fix the new select merge API.