Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Make bucket range test more maintainable #580

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Make bucket range test more maintainable #580

merged 1 commit into from
Mar 14, 2023

Conversation

Rustin170506
Copy link
Contributor

  • remove useless convert
  • use some consts to make bucket range test more maintainable

simonswine
simonswine approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that makes it a lot more readable.

LGTM

@simonswine simonswine merged commit 1bc3eb4 into grafana:main Mar 14, 2023
@Rustin170506 Rustin170506 deleted the rustin-patch-test branch March 15, 2023 06:05
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
@Rustin170506
Make bucket range test more maintainable (grafana/phlare#580)
703a0f6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rustin170506 @simonswine