Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Update to setup-go@v4 github action #602

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Conversation

cyriltovena
Copy link
Collaborator

hoping caching will works in github actions.

Seems like we are go downloading everything, everytime.

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In theory this line should only throw the cache away when go.mod changes:

key: ${{ runner.os }}-go-build-${{ matrix.go-version }}-${{ hashFiles('**/go.sum') }}

@cyriltovena cyriltovena merged commit 659940c into main Apr 3, 2023
@cyriltovena cyriltovena deleted the cache-go-workspace branch April 3, 2023 11:45
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants