This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Dedupe merge improvement. #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
May 9, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* Avoid creating a new goroutine for every profiles when deduping * Removes gzip compression when using querier * Removes next async * Only async for the first batch * Do not sort in ingester and reduce batch size * Reuse rewrite array * Revert batch size * Add a span * Loser tree * Correctly count dupe * Removes allocations from At * Remove allocation from the keep responses * Removes gzip compression change * Fetch the first batch async * Removes sort change. * make fmt lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the deduping of profiles using a loser tree implementation from @bboreham.
A bit part of it is also a bug where we would create a goroutine for each profile inspected.
The PR also adds some more instrumentation and a benchmark for future improvements I'm planning to do on the merge of stracktraces.
Currently stacktraces are not merge in the benchmark but I plan to followup on this.