Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Add test cases for getSeriesRef #659

Merged

Conversation

simonswine
Copy link
Collaborator

@simonswine simonswine commented Apr 26, 2023

This are additional test cases from the PR #621, which we reverted as a hotfix.

@simonswine simonswine marked this pull request as ready for review April 26, 2023 16:21
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I am sorry for Introducing that bug.

We may need to remove that binary search todo.

This are additional test cases from the PR grafana#621, which we reverted.
@simonswine simonswine force-pushed the 20230426_bring-back-additional-tests branch from 7b4374e to e9e0cca Compare April 27, 2023 09:07
@simonswine
Copy link
Collaborator Author

Looks good to me!

I am sorry for Introducing that bug.

We may need to remove that binary search todo.

No problem at all, I also should have really caught that in the review/tests 😆

@simonswine simonswine enabled auto-merge (squash) April 27, 2023 09:10
@simonswine simonswine merged commit 8b780de into grafana:main Apr 27, 2023
simonswine added a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
This are additional test cases from the PR grafana/phlare#621, which we reverted.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants