This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
fix: routing #737
Merged
fix: routing #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jun 30, 2023
* share same history instance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #722
Funnily enough I couldn't reproduce in CI, but trust me
bro, the issue is indeed happening.But basically for
redux-query-syncto work, the samehistoryinstance needs to be shared across the app. Didn't dive too deep, but it was affecting how other components that use theuseLocationwere rendered. BasicallySidebarwouldn't rerender when the route changes, therefore its navigation items wouldn't include the query parameter!