This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Improve Stacktraces Samples Memory Layout #801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce a new way to abstract away the memory representation and the file format on disk (parquet). The implementation heavily relies on
parquet.RowReader
it uses this new abstraction to represent stacktraces samples differently.
Instead of using a slice of struct such as :
It uses a double slice :
This highly reduce the amount of memory while ingesting profiles since we use less adress space. On top of that we don't use reflection anymore when flushing Profiles by using a custom parquet serialisation.
This is running in dev and has reduce memory usage by 50%