This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Add TotalValue per profile #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Jul 4, 2023
Comment on lines
-368
to
+372
| if err := mergeByLabels(ctx, b.profiles.file, rows, m, by...); err != nil { | ||
| columnName := "TotalValue" | ||
| if b.meta.Version == 1 { | ||
| columnName = "Samples.list.element.Value" | ||
| } | ||
| if err := mergeByLabels(ctx, b.profiles.file, columnName, rows, m, by...); err != nil { |
There was a problem hiding this comment.
To double check: we haven't released v2 yet, so we don't need another version bump, right? My understanding is that main tip already writes blocks v2
There was a problem hiding this comment.
v2 is only in dev
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 18, 2023
* Sort Profiles across row groups when flushing blocks * Refactor and properly tests parquet reader and writer * moar tests * Fixes bad uint32 to int32 conversion causing maxval to be min * add working tests back * add missing tests back * improve less function for profile rows * Adds total value per profile for building merge by series
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to compute value per series without having to look at every sample.
I decided to go with v2 meta since we haven't released it yet so it will break in dev. Turns out the repeatedPageIterator also works for non-repeated column :).