Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Sanitize profile from zero value samples and bytes label. #81

Merged
merged 5 commits into from
Jul 21, 2022

Conversation

cyriltovena
Copy link
Collaborator

No description provided.

@cyriltovena cyriltovena marked this pull request as ready for review July 18, 2022 08:40
@cyriltovena cyriltovena requested a review from simonswine July 18, 2022 08:40
@cyriltovena
Copy link
Collaborator Author

Ready this time created samber/lo#184 hoping to get it merged.

@cyriltovena
Copy link
Collaborator Author

ho the CI is flaky taking a look at this

Copy link
Collaborator

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


// RemoveInPlace removes all elements from a slice that match the given predicate.
// Does not allocate a new slice.
func RemoveInPlace[T any](collection []T, predicate func(T) bool) []T {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's useful 👍

@cyriltovena cyriltovena merged commit 74e3b10 into main Jul 21, 2022
@cyriltovena cyriltovena deleted the distributor-sanitize branch July 21, 2022 13:07
simonswine pushed a commit to simonswine/pyroscope that referenced this pull request Jun 30, 2023
Sanitize profile from zero value samples and bytes label.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants