This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
Fix app selector scrolling #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rperry2174
commented
Jul 13, 2023
| @@ -134,6 +147,54 @@ export const SelectorModalWithToggler = ({ | |||
| return selectedApp?.__profile_type__ === a.__profile_type__; | |||
| }; | |||
|
|
|||
| const groups = useMemo(() => { | |||
| const allGroups = leftSideApps.map((app) => app.name.split('-')[0]); | |||
There was a problem hiding this comment.
I guess here we should maybe use service_name and simply calculate the height of the dropdown based off the number of service_name.
If I'm understanding correctly the idea here is to:
- Calculate the necessary height of the modal based off the number of "groups" that will exist
- If the modal is bigger than the screen then set the modal to slightly bigger height than the screen... if the modal is smaller than the screen then just adapt to the size of the modal
right now the logic is assuming that the "groups" are differentiated by the text before the first - but thats not true. I guess they are now based off of the service_name?
There was a problem hiding this comment.
this isn't super helpful because I just cheated so I could make the dropdown very high by adding random numbers to each name, but for production data, for example, will the height of the modal will be determined by the unique number of service_names
petethepig
approved these changes
Jul 14, 2023
This was referenced Jul 14, 2023
simonswine
pushed a commit
to simonswine/pyroscope
that referenced
this pull request
Jul 18, 2023
* Fix app selector scrolling * comment out stuff * Remove comments * Remove item duplicator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the:
And then I asked for some help from chatgpt to bring some functionality from the pyroscope version into the phlare version.
Had to make some tweaks after, but now it looks better. Would like to merge this and get it into the next weekly release for phlare so we can then add it to the Grafana cloud profiles app plugin which imports the ui from phlare.
Fixes app selector scrolling
Screen.Recording.2023-07-13.at.3.12.56.PM.mov