Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prune tree based on MaxNodes when converting json files #1875

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Feb 23, 2023

Closes #1874

Not quite sure about memory usage of this

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

Flamegraph.com report

pyroscope-oss.frontend.cpu.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_objects.json
See in flamegraph.com
pyroscope-oss.frontend.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 1006.86 KB (0%) 20.2 s (0%) 4 s (+0.78% 🔺) 24.1 s
webapp/public/assets/app.css 19.9 KB (0%) 398 ms (0%) 0 ms (+100% 🔺) 398 ms
webapp/public/assets/styles.css 9.6 KB (0%) 192 ms (0%) 0 ms (+100% 🔺) 192 ms
packages/pyroscope-flamegraph/dist/index.js 632.77 KB (0%) 12.7 s (0%) 1.9 s (+31.49% 🔺) 14.6 s
packages/pyroscope-flamegraph/dist/index.node.js 633.47 KB (0%) 12.7 s (0%) 712 ms (-23.8% 🔽) 13.4 s
packages/pyroscope-flamegraph/dist/index.css 8.11 KB (0%) 163 ms (0%) 0 ms (+100% 🔺) 163 ms

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

Flamegraph.com report

pyroscope-oss.alloc_objects.json
See in flamegraph.com
pyroscope-oss.alloc_space.json
See in flamegraph.com
pyroscope-oss.cpu.json
See in flamegraph.com
pyroscope-oss.goroutines.json
See in flamegraph.com
pyroscope-oss.inuse_objects.json
See in flamegraph.com
pyroscope-oss.inuse_space.json
See in flamegraph.com

Created by Flamegraph.com Github Action

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 63.28% // Head: 63.28% // No change to project coverage 👍

Coverage data is based on head (c147d10) compared to base (f3882fd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1875   +/-   ##
=======================================
  Coverage   63.28%   63.28%           
=======================================
  Files         175      175           
  Lines        5912     5912           
  Branches     1587     1587           
=======================================
  Hits         3741     3741           
  Misses       2162     2162           
  Partials        9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eh-am eh-am requested a review from kolesnikovae February 23, 2023 19:14
Copy link
Collaborator

@kolesnikovae kolesnikovae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eh-am eh-am marked this pull request as ready for review February 24, 2023 12:48
@eh-am eh-am merged commit 4129a30 into main Feb 24, 2023
@eh-am eh-am deleted the chore/json-prune-tree branch February 24, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converting profiles from JSON doesn't prune nodes
2 participants