Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IteratorResult pool usage #2138

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix IteratorResult pool usage #2138

merged 1 commit into from
Jul 20, 2023

Conversation

kolesnikovae
Copy link
Collaborator

I'm not fully sure this solves the problem mentioned #2137 but should alleviate it at least

@kolesnikovae kolesnikovae requested a review from simonswine July 20, 2023 07:47
@kolesnikovae kolesnikovae linked an issue Jul 20, 2023 that may be closed by this pull request
Investigate IteratorResult pool usage and performance #2137
Closed
simonswine
simonswine approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Yes that should make IteratorResult reuse a lot more likely

@kolesnikovae kolesnikovae merged commit e26caf5 into next Jul 20, 2023
@kolesnikovae kolesnikovae deleted the fix/result-iterator-pool branch July 20, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonswine simonswine simonswine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate IteratorResult pool usage and performance
2 participants
@kolesnikovae @simonswine