-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove dependency on pyroscope-oss git branch #2143
fix: remove dependency on pyroscope-oss git branch #2143
Conversation
also, fix repository entry in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Don't forget to update scripts/webpack/webpack.common.ts too! too!
"@pyroscope/flamegraph/*": [ | ||
"./node_modules/pyroscope-oss/packages/pyroscope-flamegraph/*" | ||
], | ||
"@pyroscope/models/*": [ | ||
"./node_modules/pyroscope-oss/packages/pyroscope-models/*" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note these refer to the packages
dir, I think they still need to be aliased? Or does the workspaces
bit in package.json handles that somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or does the workspaces bit in package.json handles that somehow?
Yes, that appears to be the case. But I am getting the sense that some of the aliases are clashing with the workspaces in certain circumstances. I will continue trying things.
Don't forget to update scripts/webpack/webpack.common.ts too! too!
Thanks for the note. However, my attempts to fix webpack.common.ts
are meeting with failure locally.
I am thinking some old "node_modules" imports are still cached, so the current "passed tests" might be a misleading positive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will get rid of the "workspace" entries, and just use aliases at this stage.
I will verify this a little more closely tomorrow. |
@eh-am, the frontend code that is now in "og" has a lot of elaborate testing which I don't suspect has been replicated for the new root of the project. What approach would you recommend for adapting it over to work with the new project root, and all of its overrides? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Now that they live in the same branch on this repository, remove the layer of cross repository dependency on the "og main" branch of "pyroscope-oss" and instead use the subpackages in the new
/og
subdirectory.