Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dskit to remove direct dependency on weaveworks/common #2207

Conversation

charleskorn
Copy link
Contributor

This PR upgrades dskit and replaces use of packages from weaveworks/common with their migrated equivalents in dskit. See grafana/dskit#342 for more details.

Note that there is still an indirect dependency on weaveworks/common through the use of github.com/grafana/mimir/pkg/storegateway in pkg/querier. This will be resolved by upgrading the dependency on Mimir once grafana/mimir#5672 is merged.

If this PR needs to be rebuilt, I used rewrite.sh (source) to generate most of these changes.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@charleskorn charleskorn marked this pull request as ready for review August 4, 2023 01:55
@charleskorn charleskorn requested a review from a team as a code owner August 4, 2023 01:55
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. LGTM

@simonswine simonswine merged commit 4832d64 into grafana:next Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants