Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet docs #2252

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Update dotnet docs #2252

merged 2 commits into from
Aug 15, 2023

Conversation

Rperry2174
Copy link
Contributor

Updates dotnet docs

@Rperry2174 Rperry2174 requested review from a team as code owners August 15, 2023 03:05
@Rperry2174 Rperry2174 enabled auto-merge (squash) August 15, 2023 03:06
@Rperry2174 Rperry2174 requested a review from korniltsev August 15, 2023 03:06
Copy link
Collaborator

@korniltsev korniltsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we say here to replace and placeholders, however the placeholders are only used later in the separate section in a separate example

It feels like in the table it should not suggest to replace anyhting , especially in further examples and just state. "this is http basic auth. you need it if you send profiles to atuhenticated pyroscope server, for example grafana cloud"

@Rperry2174 Rperry2174 requested a review from korniltsev August 15, 2023 10:49
@Rperry2174 Rperry2174 merged commit cb55a4f into next Aug 15, 2023
@Rperry2174 Rperry2174 deleted the update-dotnet-docs branch August 15, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants