chore: Add dotnet SDKv8 support for examples #3493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a multi-stage build in order to overcome build problems on sdk7+ on Rosetta based macs. It will cross compile using the linxu/arm64 dotnet sdk for the linux/amd64 target.
simonswine
force-pushed
the
20240816_dotnet-sdk8
branch
from
f473c2d to
f8e3278
Compare
|
Wonder if you guys could give it a try @bryanhuhta @korniltsev |
simonswine
commented
Aug 16, 2024
| @@ -22,6 +41,7 @@ ENV PYROSCOPE_PROFILING_ENABLED=1 | |||
| ENV PYROSCOPE_PROFILING_ALLOCATION_ENABLED=true | |||
| ENV PYROSCOPE_PROFILING_CONTENTION_ENABLED=true | |||
| ENV PYROSCOPE_PROFILING_EXCEPTION_ENABLED=true | |||
| ENV PYROSCOPE_PROFILING_HEAP_ENABLED=true | |||
There was a problem hiding this comment.
This was something I would like to test, in order for it to work we need SDKv7+
simonswine
commented
Aug 16, 2024
|
|
||
| ADD example . | ||
| # We hardcode linux-x64 here, as the profiler doesn't support any other platform |
There was a problem hiding this comment.
I am fairly certain this is the case, but just double checking
korniltsev
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this problem #3288 has come back to me. 🙂
I think I have a solution now based on (dotnet/dotnet-docker#3832): It uses a multi-stage build in order to overcome build problems on dotnet sdk7+ on Rosetta based macs, when emulating amd64.
It will cross compile using the linux/arm64 dotnet sdk for the linux/amd64 target. (which is the only arch we support)