feat: fetch recording rules from tenant-settings #3874
Conversation
| for _, matcher := range rec.rule.matchers { | ||
| exportedLabels = append(exportedLabels, labels.Label{ | ||
| Name: matcher.Name, | ||
| Value: matcher.Value, |
There was a problem hiding this comment.
this was in fact a bug. I was appending name value pair, when the label value may not be the label filter value (for exmaple vehicle!="car")-
Anyway, considering removing this part as the code comment argues
There was a problem hiding this comment.
I finally removed.
| @@ -135,7 +129,7 @@ func generateExportedLabels(labelsMap map[string]string, rec *Recording, pyrosco | |||
| } | |||
|
|
|||
| func (r *Recording) matches(labelsMap map[string]string) bool { | |||
| if r.rule.profileType != labelsMap["__profile_type__"] { | |||
| if r.rule.profileType != labelsMap["__type__"] { | |||
There was a problem hiding this comment.
TODO: solve ambiguities: __type__ is not enough! block/contentions and block/delays can't be distinguish from mutex/contentions and mutex/delays
There was a problem hiding this comment.
Thanks for your work on this. I left a couple of comments in line.
In general I think this is a bit too hacky for my liking and I would prefer for use to defined types properly in protobuf and have typed API calls to return the metric rules.
The settings API currently has mostly settings about how the UI should be presenting things (collapsing, maxNodes,...), I think this is something more complex and I think this should be a separate MetricsFromProfileRulesService as part of the settingsv1 API group.
I had done very similar things for CollectorRules: #3865
A well speced out API will make the UI integration easier and will also allow it to implement proper RBAC, API permissions going forward.
| "github.com/grafana/pyroscope/api/gen/proto/go/settings/v1/settingsv1connect" | ||
| connectapi "github.com/grafana/pyroscope/pkg/api/connect" | ||
| "github.com/grafana/pyroscope/pkg/tenant" | ||
| "github.com/grafana/pyroscope/pkg/util" | ||
| ) | ||
|
|
||
| type RecordingRule struct { |
There was a problem hiding this comment.
It would be better if this is a protobuf defined type.
| } | ||
| } | ||
|
|
||
| func parseMatchers(matchersString string, serviceName string) []*labels.Matcher { |
There was a problem hiding this comment.
github.com/prometheus/prometheus/promql/parser.ParseMetricSelector should be used
This is a draft. Plenty of assumptions have been done. WIP