chore(otel): support ingesting offcpu #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Should we "hide" the json extension to trick github? .fixture, .bin, .golden
There was a problem hiding this comment.
If by hiding you mean to make github not show the diff, then I'd prefer seeing the diff.
If you mean something else, then I'm not understanding it.
kolesnikovae
approved these changes
Feb 3, 2025
Co-authored-by: Marc Sanmiquel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For off cpu profiles, the ebpf profiler sends timestamps and times in each sample.
Each sample has different
Valuefile length. it seems impossible to represent this in pprof, so I'm aggregating them to a single value.Furthermore use a separate
off_cpuinstead ofprocess_cpuprofile name.