Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: dotnet tracing example #3891

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

doc: dotnet tracing example #3891

wants to merge 2 commits into from
+587 −1

Conversation

alsoba13
Copy link
Contributor

@alsoba13 alsoba13 commented Feb 5, 2025

No description provided.

@alsoba13 alsoba13 requested review from a team as code owners February 5, 2025 10:54
aleks-p
aleks-p reviewed Feb 5, 2025
View reviewed changes
examples/tracing/dotnet/musl.Dockerfile Outdated
@@ -0,0 +1,48 @@
ARG SDK_VERSION=8.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Dockerfile used anywhere? If valid and working, we could point one of the services in the docker-compose to it, otherwise we can remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. We could use it in our docker-compose, but there are already more than one example using it. I'll will remove it from this example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleks-p aleks-p aleks-p left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alsoba13 @aleks-p