examples: Add pyroscope relabel componet in rideshare-alloy example #3894
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolesnikovae
approved these changes
Feb 6, 2025
| @@ -45,7 +45,7 @@ pyroscope.write "backend" { | |||
| # Pull latest images | |||
| docker pull grafana/pyroscope:latest | |||
| docker pull grafana/grafana:latest | |||
| docker pull grafana/alloy:latest | |||
| docker pull grafana/grafana/alloy-dev:latest | |||
There was a problem hiding this comment.
We should be careful with use of dev images in examples, esp. latest. Users may not notice that and replicate it in production.
Suggested change
| docker pull grafana/grafana/alloy-dev:latest | |
| docker pull grafana/alloy-dev:latest |
korniltsev
reviewed
Feb 6, 2025
| regex = "ride-sharing-app.*" | ||
| replacement = "backend" | ||
| } | ||
| rule { |
There was a problem hiding this comment.
I think we should add example of how to drop targets, for example drop 10% of service-a and 20% of service-b
korniltsev
reviewed
Feb 6, 2025
| // Add component label based on application name | ||
| rule { | ||
| action = "replace" | ||
| source_labels = ["__name__"] |
There was a problem hiding this comment.
__name__ is a profile name like process_cpu or memory . I am not understanding why is it compared against ride-sharing-app.*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the rideshare-alloy example by adding label enrichment capabilities to demonstrate how to add meaningful metadata to profiles through the
pyroscope.relabelcomponent.