Fix 'tk show' and 'tk diff' in docker image #232

bastjan · 2020-03-05T15:12:50Z

Busybox less does not support --RAW-CONTROL-CHARS; tk show and tk diff fail in an unmodified alpine image.

Fixed by installing the full-fledged less.

Before:

> docker run -v `pwd`:/conf -w /conf -it grafana/tanka:latest show environments/dev
less: unrecognized option: RAW-CONTROL-CHARS
BusyBox v1.31.1 () multi-call binary.

Usage: less [-EFIMmNSRh~] [FILE]...
[...]

Dockerfile

Busybox less does not support `--RAW-CONTROL-CHARS`; `tk show` and `tk diff` fail in an unmodified alpine image.

sh0rez

🚀

sh0rez · 2020-03-05T15:41:44Z

Thanks a lot @bastjan!!

rfratto requested a review from sh0rez March 5, 2020 15:13

sh0rez requested changes Mar 5, 2020

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

malcolmholmes reviewed Mar 5, 2020

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

Fix 'tk show' and 'tk diff' in docker image

c5e0299

Busybox less does not support `--RAW-CONTROL-CHARS`; `tk show` and `tk diff` fail in an unmodified alpine image.

bastjan force-pushed the patch-1 branch from 45f9467 to c5e0299 Compare March 5, 2020 15:18

sh0rez approved these changes Mar 5, 2020

View reviewed changes

sh0rez merged commit f1ed203 into grafana:master Mar 5, 2020

hamishforbes mentioned this pull request Jun 11, 2020

tk show pager improvements #293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 'tk show' and 'tk diff' in docker image #232

Fix 'tk show' and 'tk diff' in docker image #232

bastjan commented Mar 5, 2020

sh0rez left a comment

sh0rez commented Mar 5, 2020

Fix 'tk show' and 'tk diff' in docker image #232

Fix 'tk show' and 'tk diff' in docker image #232

Conversation

bastjan commented Mar 5, 2020

sh0rez left a comment

Choose a reason for hiding this comment

sh0rez commented Mar 5, 2020