Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-jsonnet to v0.18.0 #660

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Update go-jsonnet to v0.18.0 #660

merged 1 commit into from
Jan 25, 2022

Conversation

julienduchesne
Copy link
Member

jvrplmlmn
jvrplmlmn approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@jvrplmlmn jvrplmlmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Duologic
Copy link
Member

Duologic commented Jan 3, 2022

I think we need to discuss on whether we keep parseYaml or use upstream, no?

@julienduchesne
Copy link
Member Author

I think we need to discuss on whether we keep parseYaml or use upstream, no?

Hmm, yeah. Good point

@olegmayko
Copy link
Contributor

It would be nice if you merge and cut release soon. Some std.functions are long expected. Thank you!

@julienduchesne
Copy link
Member Author

It would be nice if you merge and cut release soon. Some std.functions are long expected. Thank you!

👍 . I was aiming for a release next week

@julienduchesne
Copy link
Member Author

We'll be leaving std.native("parseYaml") for now to not break compatibility

@julienduchesne julienduchesne merged commit 2b23c6f into main Jan 25, 2022
@julienduchesne julienduchesne deleted the julienduchesne/update-go-jsonnet branch January 25, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvrplmlmn jvrplmlmn jvrplmlmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@julienduchesne @Duologic @olegmayko @jvrplmlmn