reyacc

grafana · Apr 30, 2024 · a149fde · a149fde
1 parent 108d17d
commit a149fde
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 41 deletions.
diff --git a/pkg/traceql/expr.y.go b/pkg/traceql/expr.y.go
diff --git a/pkg/traceql/parse_test.go b/pkg/traceql/parse_test.go
@@ -882,7 +882,7 @@ func TestAttributeNameErrors(t *testing.T) {
 		{in: "{ . foo }", err: newParseError("syntax error: unexpected END_ATTRIBUTE, expecting IDENTIFIER", 1, 3)},
 		{in: `{ . "foo" }`, err: newParseError("syntax error: unexpected END_ATTRIBUTE, expecting IDENTIFIER", 1, 3)},
 		{in: "{ .foo .bar }", err: newParseError("syntax error: unexpected .", 1, 8)},
-		{in: "{ parent. }", err: newParseError("syntax error: unexpected END_ATTRIBUTE, expecting IDENTIFIER or resource. or span.", 0, 3)},
+		{in: "{ parent. }", err: newParseError("syntax error: unexpected END_ATTRIBUTE", 0, 3)}, // yacc only allows up to 4 toks, we have 6 combinations of parent. now
 		{in: ".3foo", err: newParseError("syntax error: unexpected IDENTIFIER", 1, 3)},
 		{in: `{ ."foo }`, err: newParseError(`unexpected EOF, expecting "`, 0, 3)},
 	}