Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vParquet3 the default #2721

Closed
2 tasks
stoewer opened this issue Jul 28, 2023 · 3 comments · Fixed by #3134
Closed
2 tasks

Make vParquet3 the default #2721

stoewer opened this issue Jul 28, 2023 · 3 comments · Fixed by #3134
Labels
keepalive Label to exempt Issues / PRs from stale workflow

Comments

@stoewer
Copy link
Contributor

stoewer commented Jul 28, 2023

Make vParquet3 the default encoding for Tempo

  • Tempo uses vParquet3 by default
  • Update documentation: just write vParquet3 everywhere where vParquet2 is mentioned as a default (mostly the configuration section)
@knylander-grafana
Copy link
Contributor

knylander-grafana commented Aug 30, 2023

Instructions for Parquetv3 to enable it: https://grafana.com/docs/tempo/next/configuration/parquet/

  • We need to update to make it the default
  • Configuration section: if we don't make it default - then we need to add a content note with public preview, experimental, etc.

Dedicated columns:

  • Basic content: https://grafana.com/docs/tempo/next/operations/dedicated_columns/
  • Main benefit is search performance - can expect up to 50% performance improvement
  • Highlight more about which scenarios where it's useful, and how powerful it is - including an example; link to other performance improvements
  • Performance is based on the data that is stored not on the configuration of the system

Mention dedicated columns in Tune search performance and link to dedicated columns doc: https://grafana.com/docs/tempo/next/operations/backend_search/

  • Consider highlighting potential search improvements and provide an example -- link to the dedicated columns
  • Minimum: Update the note at the top of the page with a link to Dedicated columns
    For example:
    Note: All forms of search (TraceQL and tags based) are only supported on the vParquet and forward blocks. v2 blocks can only be used for trace by id lookup. vParquet3 offers increased search performance by using dedicated columns.

Update Parquet schema

  • Clarify that the dedicated columns section is actually Dedicated attribute columns and search through the other pages for 'dedicated columns' to make sure it is the correct usage: either Dedicated columns for v3 or dedicated attribute columns
    • Find another name for dedicated attribute columns - in the code we're using Well-known attributes - this is a sub-set of the OTEL ones
    • These attributes follow the OTEL naming convention. This should be highlighted in the description as a differentiating factor.
    • The attributes are mentioned in the OTEL semantics (at least some of them) -- link to OTEL doc
    • For more details around semantic naming conventions, refer to the Recommendations for OpenTelemetry Authors and OpenTelemetry Semantic Conventions documentation.
  • Update the schema for the dedicated columns (vParquet3)

Troubleshooting doc?

  • Are there any troubleshooting content that we should add for vParquet? If so, this would go on the Configure > Parquet page
  • There still isn't a good tool for manipulating parquet data (we used to have a page for this type of thing but the tool was not maintained)

@github-project-automation github-project-automation bot moved this from Todo to Done in Tempo squad Aug 30, 2023
@stoewer stoewer reopened this Aug 30, 2023
@github-project-automation github-project-automation bot moved this from Done to In Progress in Tempo squad Aug 30, 2023
@stoewer stoewer moved this from In Progress to Next in Tempo squad Aug 30, 2023
@knylander-grafana
Copy link
Contributor

The benefits and wowo-factor of v3 would be a great blog post.

@stoewer stoewer self-assigned this Aug 30, 2023
@stoewer stoewer removed the type/docs Improvements or additions to documentation label Sep 4, 2023
@stoewer stoewer moved this from Next to Todo in Tempo squad Sep 4, 2023
@stoewer stoewer removed their assignment Sep 7, 2023
Copy link
Contributor

github-actions bot commented Nov 7, 2023

This issue has been automatically marked as stale because it has not had any activity in the past 60 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed after 15 days if there is no new activity.
Please apply keepalive label to exempt this Issue.

@github-actions github-actions bot added the stale Used for stale issues / PRs label Nov 7, 2023
@stoewer stoewer added keepalive Label to exempt Issues / PRs from stale workflow and removed stale Used for stale issues / PRs labels Nov 8, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Tempo squad Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Label to exempt Issues / PRs from stale workflow
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants