Make vParquet3 the default encoding #3134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoewer
requested review from
jdbaldry,
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero and
ie-pham
as code owners
stoewer
changed the title
joe-elliott
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
@stoewer Thank you for updating the doc! I've made a few suggestions, mostly to remove passive voice (which has been in the doc for a while). Do we need to make any updates for the parquet schema for vParquet3?
Co-authored-by: Kim Nylander <[email protected]>
The schema was already updated in PR containing the vParquet3 docs, this one is just about the defaults |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Now that Tempo 2.3 is released it is safe to make vParquet3 the default block encoding.
Which issue(s) this PR fixes:
Fixes #2721
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]