V1.2 compaction error fix #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
requested review from
annanay25,
dgzlopes,
joe-elliott,
yvrhdn and
mapno
as code owners
joe-elliott
approved these changes
Nov 12, 2021
|
To anyone who is interested in testing it out now, docker image was pushed as |
mdisibio
force-pushed
the
v1.2-compaction-error-fix
branch
from
0b566f4 to
3b9aad5
Compare
mdisibio
added a commit
that referenced
this pull request
Nov 15, 2021
* Skip and log empty objs in multiblockiterator, comment heavily on the predicament * oops delete comment out changes * text * changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR patches over #1107 by logging a warning and continuing instead of failing with an error. Research concludes that somehow empty traces are being written to blocks. The compactor bookmarks have already been unintentionally skipping empties in most cases, but there are a few edge cases that are not skipped and led to this error. Therefore skipping all seems ok. We have not yet determined how the empty traces originate, or what changed between 1.1 and 1.2, but this fix should alleviate 1.2 troubles for the users encountering this bug.
Which issue(s) this PR fixes:
Fixes #1107
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]