Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR makes all search-related activity (including tag lookups) case-sensitive. An original intent of this was to reduce cardinality and resource usage of ingester-search, which is extra data stored next to the actual block. Therefore this change will increase usage some, but the amount depends on the traffic. Parquet backend search will be more efficient due to the removal of
ToLower
. v2 is unaffected (was already case-sensitive).An increase in resources at the ingester is likely to cause more occurrence of #1258 so there is an attempt to fix it. We weren't able to conclusively determine the cause of such enormous buffers, but it seems related to tags that are very large. Changes:
Which issue(s) this PR fixes:
Fixes #1547 #1258
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]