-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log when a trace is too large to compact #2105
Log when a trace is too large to compact #2105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two comments. looking good!
42a31fd
to
9e848ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking good. two small comments.
i forgot that v2
and vParquet
have different paths for counting dropped spans. thank you for tracking this down. i suppose ultimately we'd prefer both act like vParquet
does, but that's too much change for this PR.
9e848ef
to
df93a32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for this improvement. It looks like there's a conflict in the changelog. If you can clean that up we'll merge.
df93a32
to
3dfe897
Compare
I cleaned changelog, thanks joe :) |
3dfe897
to
1e0a4fe
Compare
What this PR does:
Log when a trace is too large to compact.
If the total bytes of traces exceeds maximum limit, the following messages will be logged.
There will be some dicussions in this PR.
Please refer to following comments.
Which issue(s) this PR fixes:
Fixes #1931
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]