New querier API to summarize the generator metrics #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
force-pushed
the
querierMeetsGenerator
branch
2 times, most recently
from
b4d436c to
cdde2db
Compare
zalegrala
commented
May 16, 2023
zalegrala
commented
May 16, 2023
mdisibio
reviewed
May 17, 2023
zalegrala
force-pushed
the
querierMeetsGenerator
branch
2 times, most recently
from
176d2ae to
7a875e4
Compare
…les to match Signed-off-by: Zach Leslie <[email protected]>
Signed-off-by: Zach Leslie <[email protected]>
zalegrala
force-pushed
the
querierMeetsGenerator
branch
from
1866dca to
caf98a6
Compare
mdisibio
approved these changes
May 22, 2023
zalegrala
requested review from
joe-elliott,
annanay25,
mapno and
yvrhdn
as code owners
zalegrala
requested review from
electron0zero,
ie-pham and
stoewer
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we implement a new API on the queriere to summarize the GetMetrics API on the metrics generator.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]