-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetMetrics second pass + other improvements #2501
Conversation
@mdisibio Will we need any doc updates? Should we can add something to the metrics-generator doc about updating to vParquet2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lot o thoughts. i'll give some space to @zalegrala but this lgtm. i'm ready to approve if desired
} | ||
|
||
if len(matchingSpans) == 0 { | ||
if len(f.matchingSpansBuffer) == len(ss.Spans) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, i think this is safe, but i need to mention the bug where manipulating the input slice of spans caused the double add the sync pool and panic'ed everything.
we do have tests this cover this and working through this in my head makes me believe there are no issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, this looks good to me.
@knylander-grafana The default change was just for the new experimental feature that isn't documented yet, however it was reverted anyway. |
What this PR does:
Contains a variety of performance improvements mainly directed at the new dynamic metrics API. It can process several million spansets per call so it suffered from memory churn significantly more than normal search. A summary of the changes:
Currently only made the changes in vParquet2, but can backport them to vParquet after review, and can run the standard traceql benchmarks too.
Main benchmarks are mixed 🤷
Which issue(s) this PR fixes:
Fixes n/a
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]