-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run gofumpt -w
on all go files and integrate with CI
#2584
Conversation
The changes look fairly unopinionated and ok to me, a little bit cleaner than the default. Main concern is the tooling and preventing churn between contributors. A make target would be great. |
Those last few commits will do the needful. If this goes to |
gofumpt -extra -w
on all go files and integrate with CI
Enabling it to format on save in VS Code was easy following the settings snippet in https://github.com/mvdan/gofumpt#visual-studio-code However it looks like there isn't a way to include the |
Thanks for testing @mdisibio. I'm completely open to removing the |
i'm good on this as long as everything can be automated on save in popular editors. we should include details about this tool and how to set it up in |
0a98317
to
f12d4ac
Compare
gofumpt -extra -w
on all go files and integrate with CIgofumpt -w
on all go files and integrate with CI
1d866cb
to
bf87c46
Compare
What this PR does:
In working in the
tempodb
package, I notice a few areas that could use a little formatting. Here is a proposal to introduce a bit more opinionated formatting using gofumpt. After review of the changes, this has been integrated intomake fmt
to apply to the entire codebase.If we agree on these changes, we could introduce this in
tools/
and integrate as part of CI perhaps in a future PR. All editors probably have an auto-formatter as well, but worth checking on your editor. A make target could cover most of us though.Thoughts?
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]