Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to support blob storage in azure stack hub as backend #2853

Merged
merged 2 commits into from
Aug 29, 2023
Merged

to support blob storage in azure stack hub as backend #2853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0924819
to support blob storage in azure stack hub as backend
chlislb Aug 26, 2023
36ac91a
change log of #2853 pr
chlislb Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
* [BUGFIX] Fix node role auth IDMSv1 [#2760](https://github.com/grafana/tempo/pull/2760) (@coufalja)
* [BUGFIX] Only search ingester blocks that fall within the request time range. [#2783](https://github.com/grafana/tempo/pull/2783) (@joe-elliott)
* [BUGFIX] Align tempo_query_frontend_queries_total and tempo_query_frontend_queries_within_slo_total. [#2840](https://github.com/grafana/tempo/pull/2840) (@joe-elliott)
* [BUGFIX] To support blob storage in Azure Stack Hub as backend. [#2853](https://github.com/grafana/tempo/pull/2853) (@chlislb)
This query will now correctly tell you %age of requests that are within SLO:
```
sum(rate(tempo_query_frontend_queries_within_slo_total{}[1m])) by (op)
Expand Down
2 changes: 1 addition & 1 deletion tempodb/backend/azure/azure_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ func GetContainerURL(ctx context.Context, cfg *Config, hedge bool) (blob.Contain
// If the endpoint doesn't start with blob.core we can assume Azurite is being used
// So the endpoint should follow Azurite URL style
// https://learn.microsoft.com/en-us/rest/api/storageservices/get-blob#emulated-storage-service-uri
if !strings.HasPrefix(cfg.Endpoint, "blob.core") {
if !strings.HasPrefix(cfg.Endpoint, "blob.") {
u, err = url.Parse(fmt.Sprintf("http://%s/%s", cfg.Endpoint, accountName))
}

Expand Down