Configure S3's credential chain based on config #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
reviewed
Sep 5, 2023
|
@joe-elliott could we include some sort of documentation update alongside that tell what to configure for using this. |
mapno
requested review from
knylander-grafana,
annanay25,
mdisibio,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
I've updated the docs to include the new config param. Does that cover your request? |
joe-elliott
approved these changes
Sep 13, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-2889-to-release-v2.2 origin/release-v2.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 957f1606c2af309d88c456fc7a5fb5737dcbc3a9
# When the conflicts are resolved, stage and commit the changes
git add . && git cherry-pick --continueIf you have the GitHub CLI installed: # Create the PR body template
PR_BODY=$(gh pr view 2889 --json body --template 'Backport 957f1606c2af309d88c456fc7a5fb5737dcbc3a9 from #2889{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Push the branch to GitHub and a PR
echo "${PR_BODY}" | gh pr create --title "[release-v2.2] Configure S3's credential chain based on config" --body-file - --label "type/bug" --label "backport" --base release-v2.2 --milestone release-v2.2 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # If you don't have the GitHub CLI installed: Push the branch to GitHub and manually create a PR:
git push --set-upstream origin backport-2889-to-release-v2.2
# Remove the local backport branch
git switch main
git branch -D backport-2889-to-release-v2.2Unless you've used the GitHub CLI above, now create a pull request where the |
joe-elliott
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Configure S3's credential chain based on config * Changelog * Update docs (cherry picked from commit 957f160)
This was referenced Sep 13, 2023
joe-elliott
added a commit
that referenced
this pull request
Sep 13, 2023
* Configure S3's credential chain based on config * Changelog * Update docs (cherry picked from commit 957f160) Co-authored-by: Mario <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Configures the S3 credentials chain based on what S3 auth method is configured.
Added a config param to S3 config
native_aws_auth_enabled. When enabled, Tempo will use the default authentication methods of the AWS SDK for go based on known environment variables and known AWS config files.Which issue(s) this PR fixes:
Fixes #2888
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]