Increase Prometheus not found metric on tempo-vulture #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgzlopes
changed the title
joe-elliott
requested changes
Nov 2, 2020
cmd/tempo-vulture/main.go
Outdated
| @@ -115,6 +115,11 @@ func queryTempoAndAnalyze(baseURL string, backoff time.Duration, traceIDs []stri | |||
| glog.Error("tempo url ", baseURL+"/api/traces/"+id) | |||
| trace, err := util.QueryTrace(baseURL, id, tempoOrgID) | |||
| if err != nil { | |||
| if strings.Contains(err.Error(), "not found") { | |||
There was a problem hiding this comment.
It would be preferred to define and export an error from the util package like:
var ErrTraceNotFound = errors.New("trace not found")
The calling code can then compare using simple equality instead of a string.Contains method
if err == util.ErrTraceNotFound {
}
There was a problem hiding this comment.
Thanks for the review! Yep, that way it's cleaner. I'll update the PR :)
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
dgzlopes
force-pushed
the
add-trace-not-found-error
branch
from
ba559c4 to
d6b8440
Compare
joe-elliott
reviewed
Nov 2, 2020
cmd/tempo-vulture/main.go
Outdated
| @@ -115,6 +115,11 @@ func queryTempoAndAnalyze(baseURL string, backoff time.Duration, traceIDs []stri | |||
| glog.Error("tempo url ", baseURL+"/api/traces/"+id) | |||
| trace, err := util.QueryTrace(baseURL, id, tempoOrgID) | |||
| if err != nil { | |||
| if err == util.ErrTraceNotFound { | |||
There was a problem hiding this comment.
one final nit. let's reduce nesting here:
if err == util.ErrTraceNotFound {
...
}
if err != nil {
...
}
Signed-off-by: Daniel González Lopes <[email protected]>
joe-elliott
approved these changes
Nov 2, 2020
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds some things:
not found errorin case we don't find the traceID.I'm not a Go expert, but this approach seemed "reasonable" 😄
Which issue(s) this PR fixes:
Fixes #286
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]