-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parquet-go dependency #3068
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Among other changes the parquet-go update contains a fix that avoids blocks with overflows in the uncompressed page size See parquet-go/parquet-go#79
stoewer
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero and
ie-pham
as code owners
October 25, 2023 14:56
joe-elliott
approved these changes
Oct 25, 2023
changelog entry? apologies, didn't mean to close it. i hit the wrong button :). |
I now added a changelog entry |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3068-to-release-v2.3 origin/release-v2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 419288d49dae887d8887aae24e83f3407665f8f1 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3068-to-release-v2.3
# Create the PR body template
PR_BODY=$(gh pr view 3068 --json body --template 'Backport 419288d49dae887d8887aae24e83f3407665f8f1 from #3068{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release-v2.3] Update parquet-go dependency" --body-file - --label "type/bug" --label "backport" --base release-v2.3 --milestone release-v2.3 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3068-to-release-v2.3
# Create a pull request where the `base` branch is `release-v2.3` and the `compare`/`head` branch is `backport-3068-to-release-v2.3`.
# Remove the local backport branch
git switch main
git branch -D backport-3068-to-release-v2.3 |
stoewer
added a commit
to stoewer/tempo
that referenced
this pull request
Oct 26, 2023
* Update parquet-go dependency Among other changes the parquet-go update contains a fix that avoids blocks with overflows in the uncompressed page size * Update CHANGELOG.md (cherry picked from commit 419288d)
3 tasks
joe-elliott
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Update parquet-go dependency Among other changes the parquet-go update contains a fix that avoids blocks with overflows in the uncompressed page size * Update CHANGELOG.md (cherry picked from commit 419288d)
3 tasks
joe-elliott
added a commit
that referenced
this pull request
Oct 26, 2023
* Update parquet-go dependency Among other changes the parquet-go update contains a fix that avoids blocks with overflows in the uncompressed page size * Update CHANGELOG.md (cherry picked from commit 419288d) Co-authored-by: A. Stoewer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Among other changes the parquet-go update contains a fix that avoids blocks with overflows in the uncompressed page size
Which issue(s) this PR fixes:
Helps to mitigate #2987
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]