-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content negotiation support and sharding parameters for Query Frontend #375
Conversation
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
…uerier Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
So there's like 3 things going on here
Given that we know the query frontend is going to want to use HTTP I think it makes sense to drop 3 and only do 1 and 2. Thoughts? |
Hmm, Frontend is going to roundtrip GRPC to the Queriers no? It's going to reuse this - https://github.com/cortexproject/cortex/blob/master/pkg/frontend/v2/frontendv2pb/frontend.proto
This should be dropped. Was added in the PR by mistake. I don't think we need that anymore. |
I don't think the query-frontend supports GRPC. Isn't it all built around that http wrapped in grpc trick? Don't we need http on the queriers to use it without major changes? |
We can add a GRPC handler to the query frontend. QF <> Querier will be GRPC bi-directional stream. Just the payload is HTTP, but we can marshal proto into the body like we're doing between QF and Jaeger-GRPC plugin. |
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some clean up requested. This is definitely on the right path!
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes. Looking very good.
Signed-off-by: Annanay <[email protected]>
Addressed comments. @joe-elliott - This should be ready for review. |
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
What this PR does:
This PR is the first half the work to introduce a Query Frontend (follow up of #362), and does a bunch of things:
Which issue(s) this PR fixes:
Fixes #NA
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]