Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup collection of results from ingesters in the querier #4100

Merged
merged 12 commits into from
Sep 25, 2024
+199 −104
Merged

Speedup collection of results from ingesters in the querier #4100

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
203187c
Add Generic Collector for collection of things
electron0zero Sep 20, 2024
30aebf9
fix span name
electron0zero Sep 20, 2024
3f0e018
push collection down to calls to ingester
electron0zero Sep 20, 2024
2b8b2b1
drop in a TODO for testing
electron0zero Sep 20, 2024
4ebbcb8
fix fmt
electron0zero Sep 20, 2024
fb5e974
fixup generic collector
electron0zero Sep 23, 2024
f3c7600
cleanup comments and TODOs
electron0zero Sep 23, 2024
05f92a5
Update CHANGELOG.md
electron0zero Sep 23, 2024
9d6f805
match span name with func name
electron0zero Sep 24, 2024
ee9dc58
inline the collection of results in SearchRecent
electron0zero Sep 24, 2024
b8ac34b
remove break goto
electron0zero Sep 24, 2024
7a905d8
make ScopedDistinctString and DistinctString safe + test
electron0zero Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## main / unreleased

* [ENHANCEMENT] Speedup collection of results from ingesters in the querier [#4100](https://github.com/grafana/tempo/pull/4100) (@electron0zero)
* [ENHANCEMENT] Speedup DistinctValue collector and exit early for ingesters [#4104](https://github.com/grafana/tempo/pull/4104) (@electron0zero)
* [ENHANCEMENT] Add disk caching in ingester SearchTagValuesV2 for completed blocks [#4069](https://github.com/grafana/tempo/pull/4069) (@electron0zero)
* [BUGFIX] Replace hedged requests roundtrips total with a counter. [#4063](https://github.com/grafana/tempo/pull/4063) [#4078](https://github.com/grafana/tempo/pull/4078) (@galalen)
Expand Down
2 changes: 1 addition & 1 deletion modules/querier/http.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ func (q *Querier) SearchTagValuesV2Handler(w http.ResponseWriter, r *http.Reques
ctx, cancel := context.WithDeadline(r.Context(), time.Now().Add(q.cfg.Search.QueryTimeout))
defer cancel()

ctx, span := tracer.Start(ctx, "Querier.SearchTagValuesHandler")
ctx, span := tracer.Start(ctx, "Querier.SearchTagValuesV2Handler")
defer span.End()

var resp *tempopb.SearchTagValuesV2Response
Expand Down
Loading