-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_3811: send semver version in api/stattus/buildinfo for cloud deployments #4110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this!
I think it's close but I'm afraid it will break the way we've named our docker images. I've pinged a few team members who I think will have more a immediate understanding of how this works.
This reverts commit 5cbd055.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool improvement. thank you 🙏
Thanks for the patience with this PR😅🙏 |
What this PR does:
image-tag
tool is updated to validate and use the semver version, if present. Otherwise default to current behavior.Which issue(s) this PR fixes:
Fixes #3811
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]