Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_3811: send semver version in api/stattus/buildinfo for cloud deployments #4110

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

Aki0x137
Copy link
Contributor

What this PR does:

  • After every merge to main, a github action will update the VESRION file in root of project with latest tag.
  • Added a rule in Makefile for the same.
  • image-tag tool is updated to validate and use the semver version, if present. Otherwise default to current behavior.

Which issue(s) this PR fixes:
Fixes #3811

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Sep 22, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this!

I think it's close but I'm afraid it will break the way we've named our docker images. I've pinged a few team members who I think will have more a immediate understanding of how this works.

.github/workflows/update-version.yml Outdated Show resolved Hide resolved
tools/image-tag Outdated Show resolved Hide resolved
VERSION Outdated Show resolved Hide resolved
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool improvement. thank you 🙏

@joe-elliott joe-elliott merged commit 8c23c56 into grafana:main Oct 9, 2024
16 checks passed
@Aki0x137 Aki0x137 deleted the fix_3811 branch October 10, 2024 02:46
@Aki0x137
Copy link
Contributor Author

Thanks for the patience with this PR😅🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add semver version to api/status/buildinfo endpoint
5 participants