Pushdown collection of results from generators in the querier #4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
force-pushed
the
collection_generators
branch
2 times, most recently
from
80f9608 to
ce0ec8b
Compare
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
ie-pham and
stoewer
as code owners
electron0zero
force-pushed
the
collection_generators
branch
from
ce0ec8b to
fe88da5
Compare
electron0zero
force-pushed
the
collection_generators
branch
from
fe88da5 to
918ba4f
Compare
mdisibio
approved these changes
Oct 11, 2024
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Oct 11, 2024
…a#4119) * Pushdown collection of results from generators in the querier * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Iterating and then collecting the results was sync and a bottleneck for the ingester queries, and we fixed that in #4100. we did it by pushing down the collection of results and that makes it a parallel and removes the iteration step.
we can do the same for the call to generators in the queries and make them fast.
this is a follow up on #4100, as discussed #4100 (comment)
along with these changes, removed the type assertions and use of
interface{}return types fromforGivenGeneratorsand callback functionforEachGeneratorFnWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]