Correctly handle 400 Bad Request and 404 Not Found in gRPC streaming #4144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
requested review from
joe-elliott,
annanay25,
mdisibio,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
joe-elliott
approved these changes
Sep 30, 2024
| @@ -139,6 +139,8 @@ func logResult(logger log.Logger, tenantID string, durationSeconds float64, req | |||
| statusCode := -1 | |||
| if httpResp != nil { | |||
| statusCode = httpResp.StatusCode | |||
| } else if st, ok := status.FromError(err); ok { | |||
There was a problem hiding this comment.
is httpResp nil in this case?
we may also want to add this same logic to the other log methods
There was a problem hiding this comment.
The other handlers use a simpler logic that's not affected by that.
mapno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Correctly handle 400 Bad Request and 404 Not Found in gRPC streaming.
Status codes in gRPC are changed to return
InvalidArgumentfor 400 andNotFoundfor 404. Other non-special HTTP status codes areUnknown.This also allows fixing how 400 responses are counted towards SLO calculations.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]