Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add EKS Pod Identity as supported #4165

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

Rohlik
Copy link
Contributor

@Rohlik Rohlik commented Oct 10, 2024

Relates to #3899.

What this PR does:
Add EKS Pod Identity as supported.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024

CLA assistant check
All committers have signed the CLA.

@Rohlik Rohlik changed the title Add EKS Pod Identity as supported docs: Add EKS Pod Identity as supported Oct 10, 2024
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs! Is EKS pod identify supported in 2.6? If so, we'll want to backport your update.

@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label Oct 10, 2024
@knylander-grafana knylander-grafana self-assigned this Oct 10, 2024
@Rohlik
Copy link
Contributor Author

Rohlik commented Oct 10, 2024

@knylander-grafana I tested it with Tempo 2.6.0 and it works.

Copy link
Contributor

This PR must be merged before a backport PR will be created.

@knylander-grafana
Copy link
Contributor

@knylander-grafana I tested it with Tempo 2.6.0 and it works.

Thank you for testing! We can backport your change to the live 2.6 docs.

@knylander-grafana knylander-grafana merged commit 793bd5e into grafana:main Oct 11, 2024
20 of 21 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 11, 2024
Relates to #3899.

(cherry picked from commit 793bd5e)
@Rohlik Rohlik deleted the patch-1 branch October 11, 2024 06:39
electron0zero pushed a commit that referenced this pull request Oct 11, 2024
Relates to #3899.

(cherry picked from commit 793bd5e)
knylander-grafana pushed a commit to knylander-grafana/tempo-doc-work that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-v2.6 type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants