Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rhythm] Block builder performance improvement #4596

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

mdisibio
Copy link
Contributor

@mdisibio mdisibio commented Jan 22, 2025

What this PR does:
More low-hanging improvements to block builder:

  • Convert live traces to store byte slices to reduce GC scanning of complex objects. It is now a generic type and the generators still use tempopb structs. Ingesters could now make use of this too.
  • Parallelize proto unmarshal
  • Repoll prealloc slices
  • Query partition end offset and use it to avoid the last empty poll (this is mostly for benchmarking and testing, it is minor for actual performance)

This is about 20% improvement in a larger primarily single tenant cluster.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mdisibio mdisibio merged commit b980aa7 into grafana:main Jan 23, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants