Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests on limits format #657

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Add tests on limits format #657

merged 3 commits into from
Apr 20, 2021

Conversation

annanay25
Copy link
Contributor

Signed-off-by: Annanay [email protected]

What this PR does:
#656 added new json struct tags to the limits config. This PR adds tests around it - parsing/matching.

@kavirajk - Can you review this please? Also, I hope the different formats in yaml/json don't affect our deployments. For instance, notice the ingestion_rate_limit_bytes field -

	inputYAML := `
ingestion_rate_strategy: global
ingestion_rate_limit_bytes: 100_000
`
	inputJSON := `{"ingestion_rate_strategy": "global", "ingestion_rate_limit_bytes": 100000}`

Which issue(s) this PR fixes:
Fixes na!

Checklist

  • Tests updated
  • NA Documentation added
  • NA CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @annanay25 🎉

@annanay25 annanay25 merged commit c70874b into grafana:main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants