Revert Compression Updates #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b89f2ae.
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
requested review from
achatterjee-grafana,
annanay25,
dgzlopes,
yvrhdn,
mapno and
mdisibio
as code owners
Closed
zalegrala
approved these changes
Sep 21, 2021
annanay25
approved these changes
Sep 22, 2021
|
Closing in favor of #980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Reverts the bulk of #961 but keeps the fixes to block benchmarks. Issue filed against the compression repo here: klauspost/compress#442
If this is resolved (or we figure out that we are using these libraries incorrectly) we can restore klauspost snappy and s2.