Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: k6-prometheus-dashboard: Add a Max reducer function when calculating request total #174

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

monteiro-renato
Copy link

@monteiro-renato monteiro-renato commented Jan 24, 2025

Hey, I've noticed a bug in the dashboard when displaying the total http requests.

The logs were showing a considerably higher amount of requests than the aggregation displayed in the Grafana dashboard.

     http_reqs......................: 2291   7.593854/s
       { name:create dialog }.......: 2287   7.580595/s
     http_reqs......................: 2346   7.757946/s
       { name:create dialog }.......: 2342   7.744718/s
     http_reqs......................: 2436   8.046441/s
       { name:create dialog }.......: 2432   8.033228/s
     http_reqs......................: 2490   8.248169/s
       { name:create dialog }.......: 2486   8.234919/s
     http_reqs......................: 2373   7.832228/s
       { name:create dialog }.......: 2369   7.819025/s

The aggregation displayed in Grafana should be 2287 + 2342 + 2432 + 2486 + 2369 = 11916

However, we were only seeing a total of 7141 requests.

bilde

bilde

bilde

Basically, if we queried over 13:49:30, the values of the pods no longer pushing metrics were not being taken into consideration.

bilde

bilde

bilde

@monteiro-renato monteiro-renato requested a review from a team as a code owner January 24, 2025 15:00
@monteiro-renato monteiro-renato requested review from mstoykov and inancgumus and removed request for a team January 24, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant