Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update voucher client to use tokens for authentication #45

Merged
merged 5 commits into from
Nov 30, 2021
Merged

Conversation

lynnsh
Copy link
Collaborator

@lynnsh lynnsh commented Oct 5, 2021

Client:

  • added idtoken library automatically adds the authorization token to http client given the audience url (voucherURL)
  • idtoken library only works with service accounts (as per https://github.com/googleapis/google-api-go-client/issues/873), so the client reverts to http client if this is not the case

Server:

  • do not use basic auth if run in CloudRun

@rxbchen
Copy link
Collaborator

rxbchen commented Nov 16, 2021

Let's remove the reference to the internal issue 😄! Since this is a public repo

@lynnsh lynnsh marked this pull request as ready for review November 24, 2021 16:27
Copy link
Collaborator

@thepwagner thepwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an idea to reduce.

v2/cmd/voucher_server/server.go Show resolved Hide resolved
@lynnsh lynnsh merged commit 992731c into main Nov 30, 2021
@lynnsh lynnsh deleted the add-auth-client branch November 30, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants