New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth.GenerateIdToken #57

Merged

thepwagner merged 2 commits into grafeas:main from Shopify:idtoken-from-access-token

Dec 20, 2021

Collaborator

thepwagner commented Dec 17, 2021 •

edited

Loading

This should read like #56 , but decoupled from other pending changes.

I did make two functional changes from that draft:

Rather than interrogate and fetch an id_token during initialization, I moved that to the TokenSource.Token() method implementation. This avoids attempting to extract an id token in two places.
Rather than use an http.Client+JSON to request the token, I'm using the iamcredentials client.

Related

Alternative to [WIP] Another attempt at idtoken #56


          auth.GenerateIdToken

2c1006e

thepwagner self-assigned this

pull-request-size bot added the size/M label

thepwagner marked this pull request as ready for review

December 17, 2021 18:56

thepwagner mentioned this pull request

[WIP] Another attempt at idtoken #56

Closed

thepwagner requested review from rxbchen and lynnsh

December 17, 2021 19:01

lynnsh approved these changes

View reviewed changes

Collaborator

lynnsh left a comment

LGTM!

thepwagner commented

View reviewed changes

v2/cmd/voucher_client/defaultclient.go Outdated Show resolved Hide resolved


          Update v2/cmd/voucher_client/defaultclient.go

d22ae42

thepwagner merged commit 204873e into grafeas:main

thepwagner deleted the idtoken-from-access-token branch

December 20, 2021 14:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels