Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated org.grails.plugins.CodecsGrailsPlugin #12504

Closed

Conversation

rainboyan
Copy link
Contributor

Use org.grails.plugins.codecs.CodecsGrailsPlugin instead

Generate the correct descriptor grails-plugin.xml, because there are two CodecsGrailsPlugin.

@puneetbehl puneetbehl changed the base branch from 5.1.x to 5.2.x August 2, 2022 13:46
@puneetbehl puneetbehl added this to the 5.2.3 milestone Aug 3, 2022
@jeffscottbrown
Copy link
Member

This PR currently includes 161a9ff and 6d7e262 which look to be addressing separate issues. @rainboyan have you intentionally include those in this PR?

@rainboyan
Copy link
Contributor Author

This PR currently includes 161a9ff and 6d7e262 which look to be addressing separate issues.

The related PR here: #12498, #12494
and those have been merged into 5.1.x.

I don't think this PR should include those. maybe @puneetbehl knows.

@puneetbehl
Copy link
Contributor

@rainboyan I agree with Jeff's comment. I believe that should be a separate PR.

@rainboyan rainboyan closed this Sep 9, 2022
@rainboyan rainboyan deleted the deprecated_codec_grails_plugin branch September 9, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants