-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(grainlsp): Implement inlay hints for module includes #1793
Conversation
This is a minimal implementation of inlay hints. We can easily add any we want when iterating through the typed tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I had one comment but its really a style thing and either way I think this looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! 🎉 I hope the patterns were easy to follow. I had a few nit suggestions, but otherwise looks good.
…#1793) * Add initial capability for inlay hints * Added inlay hint capability * Added simple test of printing out an inline value * Debug * Cleaned up and formatted the code * Nit cleanup after review * Remove whitespace --------- Co-authored-by: marcusroberts <[email protected]>
Establish framework for adding inlay hints with the LSP.
Show hint for name of module included (useful for where the module name differs from what you might guess from the included file name)