Move processing of orderBy to runtime
#2357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 84395b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benjie
force-pushed
the
runtime-orderby
branch
from
908a81b to
92c9ee3
Compare
benjie
force-pushed
the
export-extensions-directly
branch
from
473788d to
ca506fc
Compare
benjie
force-pushed
the
runtime-orderby
branch
from
92c9ee3 to
6cf17a4
Compare
benjie
force-pushed
the
export-extensions-directly
branch
from
ca506fc to
fa005eb
Compare
benjie
force-pushed
the
runtime-orderby
branch
2 times, most recently
from
c3b5622 to
0bd16b6
Compare
benjie
force-pushed
the
runtime-orderby
branch
from
0bd16b6 to
49ea9a2
Compare
benjie
force-pushed
the
runtime-orderby
branch
from
eee4767 to
8764e3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to:
Previously dynamic ordering would need to be evaluated at plantime, causing forks in the plan. This could get expensive.
This PR changes orderBy to be evaluated at runtime, allowing operation plans to be reused in more cases.
Performance impact
Small runtime cost, but helps avoid re-planning of operations.
Security impact
Helps to reduce the surface area of planning attacks.
Checklist
yarn lint:fixpasses.yarn testpasses.RELEASE_NOTES.mdfile (if one exists).